[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions |
Date: |
Thu, 17 Jan 2013 12:55:57 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
On 01/17/2013 12:06 PM, Eduardo Habkost wrote:
> There are lots of duplicate parsing code using strto*() in QEMU, and
> most of that code is broken in one way or another. Even the visitors
> code have duplicate integer parsing code[1]. This introduces functions
> to help parsing unsigned int values: parse_uint() and parse_uint_full().
>
> Parsing functions for signed ints and floats will be submitted later.
>
>
> Changes v4:
> - Return -EINVAL in case a minus sign is found
> - Make endptr point to beginning of string in case -EINVAL
> is returned (like the strtoull() behavior)
>
> v3->v4 interdiff:
Thanks; that helped review.
The rest of the series needs no modifications to enjoy the improvements
of this v4 patch.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 5/8] vl.c: numa_add(): Validate nodeid before using it, (continued)
- [Qemu-devel] [PATCH 5/8] vl.c: numa_add(): Validate nodeid before using it, Eduardo Habkost, 2013/01/16
- [Qemu-devel] [PATCH 2/8] vl.c: Fix off-by-one bug when handling "-numa node" argument, Eduardo Habkost, 2013/01/16
- [Qemu-devel] [PATCH 6/8] vl.c: Use parse_uint_full() for NUMA nodeid, Eduardo Habkost, 2013/01/16
- [Qemu-devel] [PATCH 7/8] vl.c: Extract -numa "cpus" parsing to separate function, Eduardo Habkost, 2013/01/16
- [Qemu-devel] [PATCH 8/8] vl.c: validate -numa "cpus" parameter properly, Eduardo Habkost, 2013/01/16
- [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions, Eduardo Habkost, 2013/01/16
- Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions, Laszlo Ersek, 2013/01/17
- Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions, Eduardo Habkost, 2013/01/17
- [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions, Eduardo Habkost, 2013/01/17
- Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions, Laszlo Ersek, 2013/01/17
- Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions,
Eric Blake <=
- Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions, Blue Swirl, 2013/01/17
- Re: [Qemu-devel] [PATCH 1/8 v4] cutils: unsigned int parsing functions, Eduardo Habkost, 2013/01/17
- Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions, Markus Armbruster, 2013/01/18
- Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions, Eduardo Habkost, 2013/01/18
- Re: [Qemu-devel] [PATCH 1/8] cutils: unsigned int parsing functions, Andreas Färber, 2013/01/18
- [Qemu-devel] [PATCH 1/8 v5] cutils: unsigned int parsing functions, Eduardo Habkost, 2013/01/18
- Re: [Qemu-devel] [PATCH 1/8 v5] cutils: unsigned int parsing functions, Eric Blake, 2013/01/18
- [Qemu-devel] [PATCH 1/8 v6] cutils: unsigned int parsing functions, Eduardo Habkost, 2013/01/18
- Re: [Qemu-devel] [PATCH 1/8 v6] cutils: unsigned int parsing functions, Eric Blake, 2013/01/18
- Re: [Qemu-devel] [PATCH 1/8 v6] cutils: unsigned int parsing functions, Laszlo Ersek, 2013/01/23