Re: [Qemu-devel] [PATCH] util: Fix compilation of envlist.c for MinGW

[Stefan Weil]

Am 17.01.2013 21:45, schrieb Blue Swirl:
> On Wed, Jan 16, 2013 at 6:04 PM, Stefan Weil<address@hidden>  wrote:
> > MinGW has no strtok_r, so we need a declaration in sysemu/os-win32.h.
> > We must also fix the include statements in util/envlist.c to include
> > that file.
> >
> > We currently don't need an implementation of strtok_r because the
> > code is compiled but not linked for MinGW.
>
> I think it would be better to fix the build system so that unnecessary
> files are not compiled.

That's what I suggested first, but keeping things simple is also
a good argument. Perhaps we should accept that libqemuutil.a
can contain some unnecessary files (that's the status quo!).

We also get the additional benefit of more portable code.
Even if that portability is not needed for the moment,
it might be useful later.

Stefan