Re: [Qemu-devel] [PATCH] bswap: improve gluing

[Markus Armbruster]

Alexander Graf <address@hidden> writes:

> On 17.01.2013, at 08:50, Markus Armbruster wrote:
>
>> David Gibson <address@hidden> writes:
>> 
>>> On Sun, Jan 13, 2013 at 04:35:41PM +0000, Blue Swirl wrote:
>>>> OpenBSD system compiler (gcc 4.2.1) has problems with concatenation
>>>> of macro arguments in macro functions:
>>>>  CC    aes.o
>>>> In file included from /src/qemu/include/qemu-common.h:126,
>>>>                 from /src/qemu/aes.c:30:
>>>> /src/qemu/include/qemu/bswap.h: In function 'leul_to_cpu':
>>>> /src/qemu/include/qemu/bswap.h:461: warning: implicit declaration of 
>>>> function 'bswapHOST_LONG_BITS'
>>>> /src/qemu/include/qemu/bswap.h:461: warning: nested extern declaration of 
>>>> 'bswapHOST_LONG_BITS'
>>>> 
>>>> Function leul_to_cpu() is only used in kvm-all.c, so the warnings
>>>> are not fatal on OpenBSD without -Werror.
>>>> 
>>>> Fix by applying glue(). Also add do {} while(0) wrapping and fix
>>>> semicolon use while at it.
>>>> 
>>>> Signed-off-by: Blue Swirl <address@hidden>
>>> 
>>> Reviewed-by: David Gibson <address@hidden>
>>> 
>>> In fact, this is not merely an improvement, and not OpenBSD specific.
>>> This is a vital bugfix for all big-endian hosts.
>>> 
>>> Please apply.
>> 
>> Suggest to reword the commit message accordingly then.
>
> I don't care about the commit message, just get this patch in ASAP
> please. The current tree is broken on s390 and ppc.

I think Blue's perfectly capable to amend this commit message without
noticeable loss in commit speed.