[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2] block: do_commit() does not pass along error
|
From: |
Markus Armbruster |
|
Subject: |
Re: [Qemu-devel] [PATCH v2] block: do_commit() does not pass along error messages for all errors |
|
Date: |
Fri, 18 Jan 2013 18:11:25 +0100 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.1 (gnu/linux) |
Jeff Cody <address@hidden> writes:
> The non-live bdrv_commit() function may return one of the following
> errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is
> checked in the HMP handler is -EBUSY, so the monitor command 'commit'
> silently fails for all error cases other than 'Device is in use'.
> Return error using monitor_printf() and strerror(), and covert existing
s/covert/convert/
Suggest "Report error".
In the same vein, subject could be
block: Monitor command commit neglects to report some errors
> qerror_report() calls in do_commit() to use monitor_printf().
Patch looks good to me.