[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] block: Monitor command commit neglects to re
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH v3] block: Monitor command commit neglects to report some errors |
Date: |
Fri, 18 Jan 2013 17:37:05 -0200 |
On Fri, 18 Jan 2013 12:45:35 -0500
Jeff Cody <address@hidden> wrote:
> The non-live bdrv_commit() function may return one of the following
> errors: -ENOTSUP, -EBUSY, -EACCES, -EIO. The only error that is
> checked in the HMP handler is -EBUSY, so the monitor command 'commit'
> silently fails for all error cases other than 'Device is in use'.
>
> Report error using monitor_printf() and strerror(), and convert existing
> qerror_report() calls in do_commit() to monitor_printf().
>
> Signed-off-by: Jeff Cody <address@hidden>
Applied to the qmp branch, thanks.
> ---
> blockdev.c | 14 +++++---------
> 1 file changed, 5 insertions(+), 9 deletions(-)
>
> diff --git a/blockdev.c b/blockdev.c
> index d724e2d..cb3b426 100644
> --- a/blockdev.c
> +++ b/blockdev.c
> @@ -642,21 +642,17 @@ void do_commit(Monitor *mon, const QDict *qdict)
>
> if (!strcmp(device, "all")) {
> ret = bdrv_commit_all();
> - if (ret == -EBUSY) {
> - qerror_report(QERR_DEVICE_IN_USE, device);
> - return;
> - }
> } else {
> bs = bdrv_find(device);
> if (!bs) {
> - qerror_report(QERR_DEVICE_NOT_FOUND, device);
> + monitor_printf(mon, "Device '%s' not found\n", device);
> return;
> }
> ret = bdrv_commit(bs);
> - if (ret == -EBUSY) {
> - qerror_report(QERR_DEVICE_IN_USE, device);
> - return;
> - }
> + }
> + if (ret < 0) {
> + monitor_printf(mon, "'commit' error for '%s': %s\n", device,
> + strerror(-ret));
> }
> }
>