[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 00/27] More source reorganization and build syste
|
From: |
Blue Swirl |
|
Subject: |
Re: [Qemu-devel] [PULL 00/27] More source reorganization and build system TLC |
|
Date: |
Sat, 19 Jan 2013 10:21:51 +0000 |
On Sat, Jan 19, 2013 at 10:17 AM, Paolo Bonzini <address@hidden> wrote:
> Il 18/01/2013 19:03, Andreas Färber ha scritto:
>> I believe this broke bsd-user: util/oslib-posix.c has qemu_vmalloc()
>> guarded with
>> #if !defined(CONFIG_BSD_USER)
>> which now no longer shields it from the qemu_vmalloc() reimplementation
>> in bsd-user/mmap.c.
>>
>> Any suggestion how to fix?
>
> Does the function really needs to be called qemu_vmalloc? If not,
> having the same name for two different things is bad.
I've just sent a patch to fix this.
But new code could be introduced that used qemu_vmalloc() so I'm not
sure this approach is the best.
>
> Paolo
- Re: [Qemu-devel] [PATCH 25/27] build: some simplifications for "trace/Makefile.objs", (continued)
- [Qemu-devel] [PATCH 26/27] build: fold trace-obj-y into libqemuutil.a, Paolo Bonzini, 2013/01/12
- [Qemu-devel] [PATCH 22/27] build: move base QAPI files to libqemuutil.a, Paolo Bonzini, 2013/01/12
- [Qemu-devel] [PATCH 23/27] build: move version-obj-y to the generic LINK rule, Paolo Bonzini, 2013/01/12
- [Qemu-devel] [PATCH 27/27] build: improve quiet output for .stp rules, Paolo Bonzini, 2013/01/12
- [Qemu-devel] [PATCH 24/27] build: remove coroutine-obj-y, Paolo Bonzini, 2013/01/12
- Re: [Qemu-devel] [PULL 00/27] More source reorganization and build system TLC, Stefan Hajnoczi, 2013/01/14
- Re: [Qemu-devel] [PULL 00/27] More source reorganization and build system TLC, Andreas Färber, 2013/01/18