Re: [Qemu-devel] [PATCH for 1.4 0/4] Simplify Makefile.objs some more

[Paolo Bonzini]

Il 19/01/2013 19:11, Andreas Färber ha scritto:
>> > The patches are mostly mechanical substitutions, and there is no
>> > user-visible change---neither in total build time, nor in the files that
>> > are linked into the executables.
> Without having tested this yet I want to remind that it is necessary for
> qom/cpu.c to be built twice

Hmm, it's not anymore actually (since libuser was removed).  It hasn't
been built twice for a month and apparently nothing broke.

> , to not run into similar issues like
> util/oslib-posix.c.

The only dependency is

#if !defined(CONFIG_USER_ONLY)
    int kvm_fd;
    bool kvm_vcpu_dirty;
#endif
    struct KVMState *kvm_state;
    struct kvm_run *kvm_run;

Plenty of other fields are meaningless for !CONFIG_USER_ONLY but are
unconditionally present in struct CPUState.  Given this inconsistency,
why is it still useful to build it twice?

Paolo