qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] linux-user: correct msgrcv()


From: Laurent Vivier
Subject: Re: [Qemu-devel] [PATCH] linux-user: correct msgrcv()
Date: Sun, 20 Jan 2013 00:29:36 +0100

Le mercredi 02 janvier 2013 à 00:03 +0000, Peter Maydell a écrit :
> On 20 December 2012 21:00, Laurent Vivier <address@hidden> wrote:
> > All parameters must be swapped before the call of do_msgrcv().
> > --- a/linux-user/syscall.c
> > +++ b/linux-user/syscall.c
> > @@ -2901,7 +2901,7 @@ static inline abi_long do_msgrcv(int msqid, abi_long 
> > msgp,
> >          return -TARGET_EFAULT;
> >
> >      host_mb = g_malloc(msgsz+sizeof(long));
> > -    ret = get_errno(msgrcv(msqid, host_mb, msgsz, tswapal(msgtyp), 
> > msgflg));
> > +    ret = get_errno(msgrcv(msqid, host_mb, msgsz, msgtyp, msgflg));
> >
> >      if (ret > 0) {
> >          abi_ulong target_mtext_addr = msgp + sizeof(abi_ulong);
> > @@ -3199,7 +3199,7 @@ static abi_long do_ipc(unsigned int call, int first,
> >                      break;
> >                  }
> >
> > -                ret = do_msgrcv(first, tmp->msgp, second, tmp->msgtyp, 
> > third);
> > +                ret = do_msgrcv(first, tswapal(tmp->msgp), second, 
> > tswapal(tmp->msgtyp), third);
> >
> >                  unlock_user_struct(tmp, ptr, 0);
> >                  break;
> 
> Untested but looks right.
> Reviewed-by: Peter Maydell <address@hidden>

ping ?

Laurent
-- 
"Just play. Have fun. Enjoy the game."
- Michael Jordan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]