Re: [Qemu-devel] [PATCH v2 0/2] fix two revision related errors

[Alon Levy]

On Thu, Jan 17, 2013 at 02:02:26PM +0100, Gerd Hoffmann wrote:
> On 01/16/13 18:59, Alon Levy wrote:
> > Regarding orientation setting in windows 7 64 guest:
> > Desktop, right click->Screen resolution
> >  - You can choose Orientation: Landscape, Portrait, Landscape (flipped), 
> > Portrait (flipped)
> >  - You can choose Resolution
> >  - You can click "Advanced Settings", then "List All Modes" at the bottom, 
> > you get all the modes (i.e. four of each resolution, one for each 
> > orientation)
> 
> Ah, ok.  The driver seems to handle portrait and swap x+y when creating
> a displaysurface.  At least I get a 600x800 display upright.
> 
> I can't see a difference between Landscape + Landscape (flipped).
> Likewise Portrait + Portrait (flipped).  Is there any?

I can't actually get the "(flipped)" modes (both portrait and landscape)
to work, I get an error message "Unable to save display settings". How
did you manage to get them to work? which driver, qemu command line,
qemu version did you use?

> 
> > There are two changes after applying the "change rom size to 8192" patch:
> >  - there is no longer an Orientation option
> >  - the modes listed under "List All Modes" reduce as expected
> 
> Ok, so we loose the Portrait mode.
> 
> > Changes to the second patch:
> >  - no orientations except the normal
> 
> Keeping orientation 0+1 (and dropping the flipped 2+3 versions) should
> make the mode list small enougth that it fits while maintaining support
> for the portrait mode.

That's what I'm going to send.

> 
> I think it would also be good to fix the driver to ignore everything with or
> 
> How about that?
> 
> >  - hard code 8192 bytes rom size
> >  - assert if the required size is larger
> 
> Good.
> 
> cheers,
>   Gerd
> 
>