Re: [Qemu-devel] [PATCH 1/3] net/bitbang_mdio: Generalize etraxfs MDIO bitbanging emulation

[Andreas Färber]

Am 19.01.2013 23:28, schrieb Grant Likely:
> The etraxfs Ethernet model implements quite a nice bitbanging core. The
> change splits it out into a separate .c file. There are no functional
> changes here, just movement of code and reformatting to match qemu
> coding standards.
> 
> Cc: Peter Maydell <address@hidden>
> Cc: Paul Brook <address@hidden>
> Cc: Edgar E. Iglesias <address@hidden>
> Cc: Anthony Liguori <address@hidden>
> Signed-off-by: Grant Likely <address@hidden>
> ---
>  hw/bitbang_mdio.c     |  263 +++++++++++++++++++++++++++++++++++++++++++++++
>  hw/bitbang_mdio.h     |   72 +++++++++++++
>  hw/cris/Makefile.objs |    1 +
>  hw/etraxfs_eth.c      |  273 
> +------------------------------------------------
>  4 files changed, 337 insertions(+), 272 deletions(-)
>  create mode 100644 hw/bitbang_mdio.c
>  create mode 100644 hw/bitbang_mdio.h

If you fix coding style issues in the original file first this helps
git's copy detection. Looks like either you have it disabled for patches
or it's not detecting it at all... I would expect some "similarity N%"
notice.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg