[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/3] net/bitbang_mdio: Use bitbang core for smc9
From: |
Grant Likely |
Subject: |
Re: [Qemu-devel] [PATCH 3/3] net/bitbang_mdio: Use bitbang core for smc91c111 network device |
Date: |
Mon, 21 Jan 2013 09:12:02 -0400 |
On Sun, 20 Jan 2013 11:29:32 +0000, Peter Maydell <address@hidden> wrote:
> On 19 January 2013 22:28, Grant Likely <address@hidden> wrote:
> > The smc91c111 device has bitbanged MDIO access, but the model doesn't
> > yet implement it. This patch uses the generalized bitbang MDIO support
> > pulled out of etraxfs Ethernet driver.
>
> > @@ -44,6 +45,13 @@ typedef struct {
> > uint8_t int_level;
> > uint8_t int_mask;
> > MemoryRegion mmio;
> > +
> > + /* MDIO bus. */
> > + struct qemu_mdio mdio_bus;
> > + unsigned int phyaddr;
> > +
> > + /* PHY. */
> > + struct qemu_phy phy;
> > } smc91c111_state;
>
> This surely needs VMState additions so the extra state can be passed
> across migrations. It looks like the MDIO/PHY stuff from the etraxfs code
> doesn't have any kind of state save/restore support, so you probably need
> to first implement that in your new mdio/phy source file, and then refer
> to it here.
Ah, I see. I missed that. I will figure out how to do that and add it to
the next version.
g.