[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/6] hw/smc91c111: Add explicit 'return' rather than
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 5/6] hw/smc91c111: Add explicit 'return' rather than relying on fallthrough |
Date: |
Mon, 21 Jan 2013 12:50:55 +0000 |
Add an explicit 'return' statement to a case in smc91c111_readb
rather than relying on fallthrough to the following case's
return statement, for code clarity and to placate static analysers.
Signed-off-by: Peter Maydell <address@hidden>
---
hw/smc91c111.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/smc91c111.c b/hw/smc91c111.c
index a34698f..b605069 100644
--- a/hw/smc91c111.c
+++ b/hw/smc91c111.c
@@ -442,6 +442,7 @@ static void smc91c111_writeb(void *opaque, hwaddr offset,
return;
case 12: /* Early receive. */
s->ercv = value & 0x1f;
+ return;
case 13:
/* Ignore. */
return;
--
1.7.9.5
- [Qemu-devel] [PATCH 0/6] arm devices: mark or remove implicit fallthroughs, Peter Maydell, 2013/01/21
- [Qemu-devel] [PATCH 3/6] hw/omap_dma, hw/omap_spi: Explicitly mark fallthroughs, Peter Maydell, 2013/01/21
- [Qemu-devel] [PATCH 5/6] hw/smc91c111: Add explicit 'return' rather than relying on fallthrough,
Peter Maydell <=
- [Qemu-devel] [PATCH 1/6] hw/arm_sysctl.c: Add missing 'break' statements, Peter Maydell, 2013/01/21
- [Qemu-devel] [PATCH 4/6] hw/pflash_cfi02.c: Mark deliberate fallthrough, Peter Maydell, 2013/01/21
- [Qemu-devel] [PATCH 2/6] hw/omap1.c: Add fallthrough markers and breaks, Peter Maydell, 2013/01/21
- [Qemu-devel] [PATCH 6/6] hw/pxa2xx_timer: Explicitly mark fallthroughs, Peter Maydell, 2013/01/21
- Re: [Qemu-devel] [PATCH 0/6] arm devices: mark or remove implicit fallthroughs, Blue Swirl, 2013/01/21
- Re: [Qemu-devel] [PATCH 0/6] arm devices: mark or remove implicit fallthroughs, Blue Swirl, 2013/01/26