[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/6] hw/omap1.c: Add fallthrough markers and breaks
From: |
Peter Maydell |
Subject: |
[Qemu-devel] [PATCH 2/6] hw/omap1.c: Add fallthrough markers and breaks |
Date: |
Mon, 21 Jan 2013 12:50:52 +0000 |
Explicitly mark cases where we are deliberately falling
through to the following code. In one case we insert a
'break' instead of falling through to a 'break', as this
seems slightly clearer.
Signed-off-by: Peter Maydell <address@hidden>
---
hw/omap1.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/omap1.c b/hw/omap1.c
index e85f2e2..cc19893 100644
--- a/hw/omap1.c
+++ b/hw/omap1.c
@@ -529,6 +529,7 @@ static uint64_t omap_ulpd_pm_read(void *opaque, hwaddr addr,
case 0x28: /* Reserved */
case 0x2c: /* Reserved */
OMAP_BAD_REG(addr);
+ /* fall through */
case 0x00: /* COUNTER_32_LSB */
case 0x04: /* COUNTER_32_MSB */
case 0x08: /* COUNTER_HIGH_FREQ_LSB */
@@ -633,6 +634,7 @@ static void omap_ulpd_pm_write(void *opaque, hwaddr addr,
case 0x28: /* Reserved */
case 0x2c: /* Reserved */
OMAP_BAD_REG(addr);
+ /* fall through */
case 0x24: /* SETUP_ANALOG_CELL3_ULPD1 */
case 0x38: /* COUNTER_32_FIQ */
case 0x48: /* LOCL_TIME */
@@ -1089,6 +1091,7 @@ static void omap_mpui_write(void *opaque, hwaddr addr,
/* Not in OMAP310 */
case 0x14: /* DSP_STATUS */
OMAP_RO_REG(addr);
+ break;
case 0x18: /* DSP_BOOT_CONFIG */
case 0x1c: /* DSP_MPUI_CONFIG */
break;
--
1.7.9.5
- [Qemu-devel] [PATCH 0/6] arm devices: mark or remove implicit fallthroughs, Peter Maydell, 2013/01/21
- [Qemu-devel] [PATCH 3/6] hw/omap_dma, hw/omap_spi: Explicitly mark fallthroughs, Peter Maydell, 2013/01/21
- [Qemu-devel] [PATCH 5/6] hw/smc91c111: Add explicit 'return' rather than relying on fallthrough, Peter Maydell, 2013/01/21
- [Qemu-devel] [PATCH 1/6] hw/arm_sysctl.c: Add missing 'break' statements, Peter Maydell, 2013/01/21
- [Qemu-devel] [PATCH 4/6] hw/pflash_cfi02.c: Mark deliberate fallthrough, Peter Maydell, 2013/01/21
- [Qemu-devel] [PATCH 2/6] hw/omap1.c: Add fallthrough markers and breaks,
Peter Maydell <=
- [Qemu-devel] [PATCH 6/6] hw/pxa2xx_timer: Explicitly mark fallthroughs, Peter Maydell, 2013/01/21
- Re: [Qemu-devel] [PATCH 0/6] arm devices: mark or remove implicit fallthroughs, Blue Swirl, 2013/01/21
- Re: [Qemu-devel] [PATCH 0/6] arm devices: mark or remove implicit fallthroughs, Blue Swirl, 2013/01/26