[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 5/5] target-i386: remove setting tsc-frequency from
From: |
Igor Mammedov |
Subject: |
[Qemu-devel] [PATCH 5/5] target-i386: remove setting tsc-frequency from x86_def_t |
Date: |
Mon, 21 Jan 2013 15:06:39 +0100 |
Setting tsc-frequency from x86_def_t is NOP because default tsc_khz
in x86_def_t is 0 and CPUX86State.tsc_khz is also initialized to 0
by default. So there is not need to set ovewrite tsc_khz with default
0 because field was already initialized to 0.
custom tsc-frequency setting is not affected due to it is being set
without using x86_def_t (previous patch)
Field tsc_khz in x86_def_t becomes unused with this patch, so drop it
as well.
Signed-off-by: Igor Mammedov <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
---
v2:
- rebased with "target-i386: move out CPU features initialization
in separate func" patch dropped
---
target-i386/cpu.c | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 640cc8f..0c30837 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -353,7 +353,6 @@ typedef struct x86_def_t {
int family;
int model;
int stepping;
- int tsc_khz;
uint32_t features, ext_features, ext2_features, ext3_features;
uint32_t kvm_features, svm_features;
uint32_t xlevel;
@@ -1555,8 +1554,6 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
env->cpuid_ext4_features = def->ext4_features;
env->cpuid_7_0_ebx_features = def->cpuid_7_0_ebx_features;
env->cpuid_xlevel2 = def->xlevel2;
- object_property_set_int(OBJECT(cpu), (int64_t)def->tsc_khz * 1000,
- "tsc-frequency", &error);
object_property_set_str(OBJECT(cpu), def->model_id, "model-id", &error);
if (error) {
--
1.7.1
- [Qemu-devel] [PATCH qom-cpu 0/5 v2] x86 CPU cleanup, part 4, Igor Mammedov, 2013/01/21
- [Qemu-devel] [PATCH 1/5] target-i386: print deprecated warning if xlevel < 0x80000000, Igor Mammedov, 2013/01/21
- [Qemu-devel] [PATCH 4/5] target-i386: set custom features/properties without intermediate x86_def_t, Igor Mammedov, 2013/01/21
- [Qemu-devel] [PATCH 3/5] target-i386: remove vendor_override field from CPUX86State, Igor Mammedov, 2013/01/21
- [Qemu-devel] [PATCH 5/5] target-i386: remove setting tsc-frequency from x86_def_t,
Igor Mammedov <=
- [Qemu-devel] [PATCH 2/5] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t, Igor Mammedov, 2013/01/21
- Re: [Qemu-devel] [PATCH qom-cpu 0/5 v2] x86 CPU cleanup, part 4, Igor Mammedov, 2013/01/21
- Re: [Qemu-devel] [PATCH qom-cpu 0/5 v2] x86 CPU cleanup, part 4, Andreas Färber, 2013/01/26