Re: [Qemu-devel] [PATCH 2/5] target-i386: replace uint32_t vendor fields by vendor string in x86_def_t

[Igor Mammedov]

On Thu, 17 Jan 2013 13:29:14 -0200
Eduardo Habkost <address@hidden> wrote:

> On Thu, Jan 17, 2013 at 04:16:31PM +0100, Igor Mammedov wrote:
> > Vendor property setter takes string as vendor value but cpudefs
> > use uint32_t vendor[123] fields to define vendor value. It makes it
> > difficult to unify and use property setter for values from cpudefs.
> > 
> > Simplify code by using vendor property setter, vendor[123] fields
> > are converted into vendor[13] array to keep its value. And vendor
> > property setter is used to access/set value on CPU.
> > 
> >  - Make for() cycle reusable for the next patch by adding
> >    x86_cpu_vendor_words2str()
> > 
> > Intel's CPUID spec[1] says:
> > "
> > 5.1.1 ...
> > These registers contain the ASCII string: GenuineIntel
> > ...
> > "
> > 
> > List[2] of known vendor values shows that they all are 12 ASCII
> > characters long, padded where necessary with space
> > 
> > Current supported values are all ASCII characters packed in
> > ebx, edx, ecx. So lets state that qemu supports 12 ASCII characters
> > packed in ebx, edx, ecx registers for cpuid(0) instruction.
> 
> Nit: I guess you mean ASCII _printable_ characters. NUL is an ASCII
> character as well, but it won't be supported.
I'll fix it. Thanks!

[...]