Re: [Qemu-devel] [PATCH v4 2/3] net: split eth_mac_addr for better error handling

[Stefan Hajnoczi]

On Sun, Jan 20, 2013 at 10:43:08AM +0800, address@hidden wrote:
> From: Stefan Hajnoczi <address@hidden>
> 
> When we set mac address, software mac address in system and hardware mac
> address all need to be updated. Current eth_mac_addr() doesn't allow
> callers to implement error handling nicely.
> 
> This patch split eth_mac_addr() to prepare part and real commit part,
> then we can prepare first, and try to change hardware address, then do
> the real commit if hardware address is set successfully.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> Signed-off-by: Amos Kong <address@hidden>
> ---
>  include/linux/etherdevice.h |  2 ++
>  net/ethernet/eth.c          | 43 ++++++++++++++++++++++++++++++++++++-------
>  2 files changed, 38 insertions(+), 7 deletions(-)

Feel free to make yourself author and put me just as Suggested-by:.  I
posted pseudo-code but didn't write the patch or test it, so it's fair
to say that credit goes to you. :)

Stefan