Re: [Qemu-devel] [PATCH v2 00/12] qdev: correct reference counting

[Anthony Liguori]

Hi,

Thank you for submitting your patch series.  checkpatch.pl has
detected that one or more of the patches in this series violate
the QEMU coding style.

If you believe this message was sent in error, please ignore it
or respond here with an explanation.

Otherwise, please correct the coding style issues and resubmit a
new version of the patch.

For more information about QEMU coding style, see:

http://git.qemu.org/?p=qemu.git;a=blob_plain;f=CODING_STYLE;hb=HEAD

Here is the output from checkpatch.pl:

Subject: qom: remove object_delete
total: 0 errors, 0 warnings, 48 lines checked

Your patch has no obvious style problems and is ready for submission.
Subject: cpu: do not use object_delete
total: 0 errors, 0 warnings, 40 lines checked

Your patch has no obvious style problems and is ready for submission.
Subject: qdev: drop extra references at creation time
total: 0 errors, 0 warnings, 56 lines checked

Your patch has no obvious style problems and is ready for submission.
Subject: qdev: inline object_delete into qbus_free/qdev_free
total: 0 errors, 0 warnings, 18 lines checked

Your patch has no obvious style problems and is ready for submission.
Subject: qdev: add reference for the bus while it is referred to by the 
DeviceState
total: 0 errors, 0 warnings, 15 lines checked

Your patch has no obvious style problems and is ready for submission.
Subject: qdev: move unrealization of devices from finalize to unparent
total: 0 errors, 0 warnings, 48 lines checked

Your patch has no obvious style problems and is ready for submission.
Subject: qdev: move deletion of children from finalize to unparent
WARNING: line over 80 characters
#35: FILE: hw/qdev.c:450:
+        assert(bus != sysbus_get_default()); /* main_system_bus is never freed 
*/

total: 0 errors, 1 warnings, 59 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.


Regards,

Anthony Liguori