[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll()
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll() |
Date: |
Tue, 22 Jan 2013 08:49:15 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 |
Il 22/01/2013 08:02, Dietmar Maurer ha scritto:
>> aio_poll() must return true if any work is still pending, even if it didn't
>> make
>> > progress, so that qemu_aio_wait() doesn't return too early.
>> > The possibility of returning early occasionally lead to a failed assertion
>> > in
>> > bdrv_drain_all(), when some in-flight request was missed and the function
>> > didn't really drain all requests.
> I still have problem with bdrv_drain_all() and my backup block job.
> If I reset/suspend/resume/ the VM during a backup job run I get:
>
> block.c:1221: bdrv_drain_all: Assertion `((&bs->tracked_requests)->lh_first
> == ((void *)0))' failed.
> Aborted
>
> I am not 100% sure, but I think a simple qemu_aio_wait() is not enough to
> ensure that
> a copy-on-write action has finished.
Are you using timers in any way?
Paolo
> Any idea how to solve that problem?
>
>
>
>
>
>
- [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Kevin Wolf, 2013/01/16
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Paolo Bonzini, 2013/01/16
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Dietmar Maurer, 2013/01/22
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(),
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Dietmar Maurer, 2013/01/22
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Paolo Bonzini, 2013/01/22
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Dietmar Maurer, 2013/01/22
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Dietmar Maurer, 2013/01/23
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Paolo Bonzini, 2013/01/23
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Dietmar Maurer, 2013/01/23
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Paolo Bonzini, 2013/01/23
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Dietmar Maurer, 2013/01/23
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Dietmar Maurer, 2013/01/24
- Re: [Qemu-devel] [PATCH] aio-posix: Fix return value of aio_poll(), Paolo Bonzini, 2013/01/24