[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file f
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format |
Date: |
Tue, 22 Jan 2013 15:34:32 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 17.01.2013 21:45, schrieb Stefan Weil:
> These patches improve the error report if the file format was
> specified explicitly (example: -drive file=myfile,format=qcow2)
> and the given format does not match the real format.
>
> They fix those bugs:
>
> https://bugzilla.redhat.com/show_bug.cgi?id=556482
> https://bugs.launchpad.net/qemu/+bug/1090600
>
> Changes in v2:
>
> * Use error code EMEDIUMTYPE instead of inventing a new one.
> * Split modifications in block/vdi.c into 3 separate patches.
>
> I decided to use EMEDIUMTYPE because I think that it matches best
> the kind of error which we want to describe here.
>
> EINVAL is too unspecific, and ENOTTY means something completely different,
> therefore I did not use one of those suggested values.
>
> Cheers,
> Stefan
>
> [PATCH v2 1/5] block: Add special error code for wrong format
> [PATCH v2 2/5] block: Use error code EMEDIUMTYPE for wrong format in
> [PATCH v2 3/5] block/vdi: Improve debug output for signature
> [PATCH v2 4/5] block/vdi: Improved return values from vdi_open
> [PATCH v2 5/5] block/vdi: Check for bad signature
Thanks, applied all to the block branch.
Kevin
- [Qemu-devel] [PATCH v2 5/5] block/vdi: Check for bad signature, (continued)
Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format, Eric Blake, 2013/01/17
Re: [Qemu-devel] [PATCH v2 0/5] block: Fix error report for wrong file format,
Kevin Wolf <=