Re: [Qemu-devel] [RFC V7 03/11] quorum: Add quorum_open() and quorum_close().

[Eric Blake]

On 01/18/2013 10:30 AM, Benoît Canet wrote:
> Valid quorum resources look like
> quorum:threshold/total:path/to/image_1: ... :path/to/image_total
> 
> ':' is used as a separator
> '\' is the escaping character for filename containing ':'
> '\' escape itself

These are true of the protocol itself,

> ',' must be escaped with ','

while this is true only of the qemu command line parser (but not if we
had a direct C interface into opening the protocol directly).  But I'm
okay with the commit message.

> 
> On the command line for quorum files "img:test.raw", "img2,raw"
> and "img3.raw" invocation look like:
> 
> -drive file=quorum:2/3:img\\:test.raw:img2,,raw:img3.raw
> (note the double \\ and the double ,,)
> 
> Signed-off-by: Benoit Canet <address@hidden>
> ---
>  block/quorum.c |  155 
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 155 insertions(+)

> +static int quorum_parse_uint_step_next(const char *start,

> +    }
> +    ret = parse_uint(start, value, next, 10);

Any reason to force decimal here, instead of allowing octal and hex by
passing 0 for base?  But I'm not too worried if you leave it this way.

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature