Re: [Qemu-devel] [PATCH v3 11/11] qemu-ga: Fix unchecked strdup() by converting to g_strdup()

[Luiz Capitulino]

On Tue, 22 Jan 2013 11:08:06 +0100
Markus Armbruster <address@hidden> wrote:

> I figure it's freed somewhere deep down in QAPI, with g_free().

It is, by qapi_dealloc_type_str().

> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>

Reviewed-by: Luiz Capitulino <address@hidden>

> ---
>  qga/commands.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/qga/commands.c b/qga/commands.c
> index 7ffb35e..528b082 100644
> --- a/qga/commands.c
> +++ b/qga/commands.c
> @@ -61,7 +61,7 @@ struct GuestAgentInfo *qmp_guest_info(Error **err)
>  
>      while (*cmd_list) {
>          cmd_info = g_malloc0(sizeof(GuestAgentCommandInfo));
> -        cmd_info->name = strdup(*cmd_list);
> +        cmd_info->name = g_strdup(*cmd_list);
>          cmd_info->enabled = qmp_command_is_enabled(cmd_info->name);
>  
>          cmd_info_list = g_malloc0(sizeof(GuestAgentCommandInfoList));