Re: [Qemu-devel] [PATCH v9 3/7] trace: Provide a detailed event control interface

[Stefan Hajnoczi]

On Wed, Jan 23, 2013 at 06:11:19PM +0100, Lluís Vilanova wrote:
> Stefan Hajnoczi writes:
> 
> > On Thu, Jan 10, 2013 at 08:23:13PM +0100, Lluís Vilanova wrote:
> >> diff --git a/trace/control-internal.h b/trace/control-internal.h
> >> new file mode 100644
> >> index 0000000..188253a
> >> --- /dev/null
> >> +++ b/trace/control-internal.h
> >> @@ -0,0 +1,67 @@
> >> +/*
> >> + * Interface for configuring and controlling the state of tracing events.
> >> + *
> >> + * Copyright (C) 2011-2012 Lluís Vilanova <address@hidden>
> >> + *
> >> + * This work is licensed under the terms of the GNU GPL, version 2 or 
> >> later.
> >> + * See the COPYING file in the top-level directory.
> >> + */
> 
> > Please add an include guard.
> 
> It is only meant to be included from "trace/control.h", and only for the sake 
> of
> maintaining declarations separated from inlined definitions.

For sanity I'd still add an include guard.

> >> +/**
> >> + * trace_print_events:
> >> + *
> >> + * Print the state of all events.
> >> + *
> >> + * Warning: This function must be implemented by each tracing backend.
> >> + *
> >> + * TODO: Should this be moved to generic code?
> 
> > This is generic code so the TODO can be removed?
> 
> No, I meant the opposite. That maybe this should *not* be in the generic 
> control
> interface, but I don't know where it should be moved to then, as it's used in
> the simple, default and stderr backends, as well as in the monitor.

I see.  For now I think this is okay and the comment can be dropped.

Stefan