Re: [Qemu-devel] [PATCH 1.4 0/2] iscsi: add support for iovectors

[Paolo Bonzini]

Il 24/01/2013 11:03, Peter Lieven ha scritto:
> Hi Paolo,
> 
> it doesn't compile for LIBISCSI_FEATURE_IOVECTOR set.
> 
> you need to put this around every access to acb->buf
> #if !defined(LIBISCSI_FEATURE_IOVECTOR)
>    acb->buf ....
> #endif

or remove the #ifdef around the declaration of the buf field.  Does it
work with that change?

Paolo

> address@hidden:~/git/qemu$ LANG=C sudo make -j8 install
>   CC    qapi-types.o
>   CC    qapi-visit.o
>   CC    qga/commands.o
>   CC    qga/guest-agent-command-state.o
>   CC    qga/main.o
>   CC    qga/commands-posix.o
>   CC    qga/channel-posix.o
>   CC    qga/qapi-generated/qga-qapi-types.o
>   CC    qga/qapi-generated/qga-qapi-visit.o
>   CC    qga/qapi-generated/qga-qmp-marshal.o
>   CC    trace/generated-tracers.o
>   AR    libqemustub.a
>   CC    thread-pool.o
>   CC    block.o
>   CC    blockjob.o
>   CC    qemu-timer.o
>   CC    block/iscsi.o
>   CC    fsdev/virtfs-proxy-helper.o
>   CC    fsdev/virtio-9p-marshal.o
>   CC    qemu-bridge-helper.o
> block/iscsi.c: In function 'iscsi_bh_cb':
> block/iscsi.c:82:15: error: 'IscsiAIOCB' has no member named 'buf'
> block/iscsi.c:83:8: error: 'IscsiAIOCB' has no member named 'buf'
> block/iscsi.c: In function 'iscsi_aio_write16_cb':
> block/iscsi.c:205:15: error: 'IscsiAIOCB' has no member named 'buf'
> block/iscsi.c:206:8: error: 'IscsiAIOCB' has no member named 'buf'
> block/iscsi.c: In function 'iscsi_aio_writev':
> block/iscsi.c:253:8: error: 'IscsiAIOCB' has no member named 'buf'
> block/iscsi.c:303:19: error: 'IscsiAIOCB' has no member named 'buf'
> block/iscsi.c: In function 'iscsi_aio_readv':
> block/iscsi.c:368:8: error: 'IscsiAIOCB' has no member named 'buf'
> block/iscsi.c: In function 'iscsi_aio_flush':
> block/iscsi.c:474:8: error: 'IscsiAIOCB' has no member named 'buf'
> block/iscsi.c: In function 'iscsi_aio_discard':
> block/iscsi.c:528:8: error: 'IscsiAIOCB' has no member named 'buf'
> block/iscsi.c: In function 'iscsi_aio_ioctl':
> block/iscsi.c:604:8: error: 'IscsiAIOCB' has no member named 'buf'
>   CC    qemu-log.o
> make: *** [block/iscsi.o] Error 1
> make: *** Waiting for unfinished jobs....
> 
> Peter
> 
> On 22.01.2013 17:37, Paolo Bonzini wrote:
>> Help testing these patches is welcome.
>>
>> Paolo Bonzini (1):
>>    iscsi: do not leak acb->buf when commands are aborted
>>
>> Peter Lieven (1):
>>    iscsi: add support for iovectors
>>
>>   block/iscsi.c | 53
>> +++++++++++++++++++++++++++++++++++++++++++----------
>>   1 file changed, 43 insertions(+), 10 deletions(-)
>>
>