Re: [Qemu-devel] [PATCH 1/8] fw_cfg: Replace debug prints by tracepoints

[Peter Lieven]

Am 24.01.2013 um 11:41 schrieb Andreas Färber <address@hidden>:

> Am 24.01.2013 11:32, schrieb Markus Armbruster:
>> Peter Lieven <address@hidden> writes:
>> 
>>> Latest git doesn't compile with this patch:
>>> 
>>> hw/fw_cfg.c: In function 'fw_cfg_write':
>>> hw/fw_cfg.c:207:5: error: implicit declaration of function
>>> trace_fw_cfg_write' [-Werror=implicit-function-declaration]
>>> hw/fw_cfg.c:207:5: error: nested extern declaration of
>>> trace_fw_cfg_write' [-Werror=nested-externs]
>>> hw/fw_cfg.c: In function 'fw_cfg_select':
>>> hw/fw_cfg.c:232:5: error: implicit declaration of function
>>> trace_fw_cfg_select' [-Werror=implicit-function-declaration]
>>> hw/fw_cfg.c:232:5: error: nested extern declaration of
>>> trace_fw_cfg_select' [-Werror=nested-externs]
>>> hw/fw_cfg.c: In function 'fw_cfg_read':
>>> hw/fw_cfg.c:247:5: error: implicit declaration of function
>>> trace_fw_cfg_read' [-Werror=implicit-function-declaration]
>>> hw/fw_cfg.c:247:5: error: nested extern declaration of
>>> trace_fw_cfg_read' [-Werror=nested-externs]
>>> hw/fw_cfg.c: In function 'fw_cfg_add_file':
>>> hw/fw_cfg.c:460:13: error: implicit declaration of function
>>> trace_fw_cfg_add_file_dupe' [-Werror=implicit-function-declaration]
>>> hw/fw_cfg.c:460:13: error: nested extern declaration of
>>> trace_fw_cfg_add_file_dupe' [-Werror=nested-externs]
>>> hw/fw_cfg.c:467:5: error: implicit declaration of function
>>> trace_fw_cfg_add_file' [-Werror=implicit-function-declaration]
>>> hw/fw_cfg.c:467:5: error: nested extern declaration of
>>> trace_fw_cfg_add_file' [-Werror=nested-externs]
>>> cc1: all warnings being treated as errors
>>> make: *** [hw/fw_cfg.o] Error 1
>> 
>> Compiles fine for me.
>> 
>> What happens if you blow away your build tree and start over?
>> 
>> In my experience, rebuilding of trace-related stuff is rather fragile...
> 
> There were some recent changes ... there's probably a stale trace.h and
> trace.c in the build directory.

removing trace.c and trace.h is not enough, but a fresh clone of the
repository works. are there any more such files?

Peter


> 
> Would be nice if we could get the build system to automatically remove
> such known stale files...
> 
> Andreas
> 
> -- 
> SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
> GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg