Re: [Qemu-devel] [PATCH] s390: Add default support for SCLP console

[Andreas Färber]

Am 24.01.2013 13:44, schrieb Alexander Graf:
> 
> On 24.01.2013, at 13:37, Andreas Färber wrote:
> 
>> Am 24.01.2013 12:23, schrieb Alexander Graf:
>>> @@ -4060,6 +4106,8 @@ int main(int argc, char **argv, char **envp)
>>>         exit(1);
>>>     if (foreach_device_config(DEV_VIRTCON, virtcon_parse) < 0)
>>>         exit(1);
>>> +    if (foreach_device_config(DEV_SCLP, sclp_parse) < 0)
>>> +        exit(1);
>>
>> Braces (seems you're not using a checkpatch.pl commit hook?)
> 
> I know, but I decided against braces here and above as it would make the code 
> completely unreadable to have braces in some cases, but not in others.

I don't see how that would make anything unreadable? It would merely add
three } lines. If you feel like it, you could optionally fix the other
occurrences first and then put your addition on top. Shouldn't cost much
time either way.

As it stands it's kind of a the-rules-don't-apply-for-me argument. :(

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg