qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx ex


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions
Date: Thu, 24 Jan 2013 18:00:33 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2

Am 24.01.2013 17:17, schrieb Richard Henderson:
> On 2013-01-24 01:35, Andreas Färber wrote:
>> Am 24.01.2013 05:02, schrieb Richard Henderson:
>>>   target-i386/cpu.c                   |   18 +-
>>>   target-i386/cpu.h                   |   24 +-
>>
>> You forgot to CC me: Please point me to where in those 57 patches you
>> are touching the core CPU code.
> 
> cpu.c:    0045: Implement MOVBE
>     0046: Implement ANDN
>     0054: Implement ADX
> 
> These modify the TCG_*_FEATURES defines as I add new extensions
> to the translator.
> 
> cpu.h:    0009: compute eflags outside rcl
>     0013: Name the cc_op enum
>     0039: optimize flags checking after sub
>     0040: Use CC_SRC2 for ADC
>     0048: Implement BLSR
>     0054: Implement ADX
> 
> These primarily have to do with the CC_OP enumeration, and the
> contents of CPUX86State.

So both cpu.c patches will need a slight rebase after 1.4, the CC_*
changes won't conflict and the fields added to CPUX86State look okay
too, used for TCG. No objections or need to coordinate from my side.

My upcoming X86CPU subclasses mini-series may conflict at the same
location again but should be trivially resolvable in either order.

Cheers,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]