Re: [Qemu-devel] [PATCH 3/3] scripts: A script to create linux container using qemu-linux-user.

[Alexander Graf]

Am 24.01.2013 um 21:16 schrieb Laurent Vivier <address@hidden>:

> Le jeudi 24 janvier 2013 à 19:05 +0100, Alexander Graf a écrit :
>> On 20.01.2013, at 00:21, Laurent Vivier wrote:
> [...]
>>> +create_root() {
>>> +    # sanity check
>>> +
>>> +    if [ $(readlink -f ${CONTAINER_PATH}/) = "/" ]
>>> +    then
>>> +        echo "ERROR: invalid path ${CONTAINER_PATH}" 1>&2
>>> +        exit 1
>>> +    fi
>>> +
>>> +    # check directory
>>> +
>>> +    if [ -e "${CONTAINER_PATH}" ]
>>> +    then
>>> +        echo "${CONTAINER_PATH} already exists" 1>&2
>>> +        echo "Please, remove it" 1>&2
>>> +        exit 1
>>> +    fi
>>> +
>>> +    # Debian bootstrap
>>> +
>>> +    mkdir -p "${CONTAINER_PATH}"
>>> +    debootstrap --foreign \
>> 
>> I don't think anything running debootstrap belongs in generically
>> sounding QEMU source code.
> 
> Why ?

Because it's a QEMU script. If you like, add a separate debian-create-rootfs 
script that you can call from this one. Then it's properly separated.

> As I said, these scripts are helper scripts for developers. If someone
> wants to use this with Fedora/RHEL distro, it is to him to add the
> "febootstrap" part. BTW, I don't know if there is this kind of tool for
> SUSE.

That would be "kiwi". :)

Alex

> 
> Regards,
> Laurent
> -- 
> "Just play. Have fun. Enjoy the game."
> - Michael Jordan
>