qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH][TRIVIAL] vl: coding style cleanups


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH][TRIVIAL] vl: coding style cleanups
Date: Fri, 25 Jan 2013 10:47:45 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2

Hi,

Am 25.01.2013 00:04, schrieb Jesse Larrew:
> 
> Reformat the option parsing code in main() and various supporting functions
> to conform to the QEMU coding style.
> 
> Signed-off-by: Jesse Larrew <address@hidden>
> ---
>  vl.c | 476 
> +++++++++++++++++++++++++++++++++++++------------------------------
>  1 file changed, 260 insertions(+), 216 deletions(-)

On a brief look this doesn't look wrong. What is the purpose of this
patch though? Is it intended for the s390x SCLP patch to be rebased
upon, or is it preparing some other actual refactoring or addition?
We don't usually do pure Coding Style refactorings without follow-ups.

Regards,
Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]