qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 12/12] qom: remove object_delete


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH v3 12/12] qom: remove object_delete
Date: Fri, 25 Jan 2013 12:56:46 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2

Am 25.01.2013 12:47, schrieb Paolo Bonzini:
> This is now unused.
> 
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  include/qom/object.h | 17 ++---------------
>  qom/object.c         |  7 -------
>  2 files changed, 2 insertions(+), 22 deletions(-)
> 
> diff --git a/include/qom/object.h b/include/qom/object.h
> index 5e8e528..2ac35a5 100644
> --- a/include/qom/object.h
> +++ b/include/qom/object.h
> @@ -553,9 +553,7 @@ struct InterfaceClass
>   * object_new:
>   * @typename: The name of the type of the object to instantiate.
>   *
> - * This function will initialize a new object using heap allocated memory.  
> This
> - * function should be paired with object_delete() to free the resources
> - * associated with the object.
> + * This function will initialize a new object using heap allocated memory.
>   *
>   * Returns: The newly allocated and instantiated object.
>   */
[snip]

Why not just update object_delete() -> object_unref() within the
documentation comment? At least somewhere we should prominently document
how these functions are to be used together.
Could be done in a follow-up of course.

Andreas



-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]