[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 03/12] qom: preserve object while unparenting
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v3 03/12] qom: preserve object while unparenting it |
Date: |
Fri, 25 Jan 2013 13:03:10 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 25.01.2013 12:46, schrieb Paolo Bonzini:
> Avoid that the object disappears after it's deleted from the QOM
> composition tree, in case that was the only reference to it.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Thought I had already added
Acked-by: Andreas Färber <address@hidden>
Andreas
> ---
> qom/object.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/qom/object.c b/qom/object.c
> index 03e6f24..1a123da 100644
> --- a/qom/object.c
> +++ b/qom/object.c
> @@ -361,12 +361,14 @@ static void object_property_del_child(Object *obj,
> Object *child, Error **errp)
>
> void object_unparent(Object *obj)
> {
> + object_ref(obj);
> if (obj->parent) {
> object_property_del_child(obj->parent, obj, NULL);
> }
> if (obj->class->unparent) {
> (obj->class->unparent)(obj);
> }
> + object_unref(obj);
> }
>
> static void object_deinit(Object *obj, TypeImpl *type)
>
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH for-1.4 v3 00/12] qdev: correct reference counting, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v3 11/12] cpu: do not use object_delete, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v3 01/12] qdev: remove duplication between qbus_create and qbus_create_inplace, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v3 08/12] qdev: add reference for the bus while it is referred to by the DeviceState, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v3 03/12] qom: preserve object while unparenting it, Paolo Bonzini, 2013/01/25
- Re: [Qemu-devel] [PATCH v3 03/12] qom: preserve object while unparenting it,
Andreas Färber <=
- [Qemu-devel] [PATCH v3 02/12] pci: use qbus_create in pci_bus_new, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v3 04/12] qom: document reference counting of link properties, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v3 05/12] qdev: add reference count to a device for the BusChild, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v3 09/12] qdev: inline object_delete into qbus_free/qdev_free, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v3 06/12] qdev: move deletion of children from finalize to unparent, Paolo Bonzini, 2013/01/25
- [Qemu-devel] [PATCH v3 07/12] qdev: move unrealization of devices from finalize to unparent, Paolo Bonzini, 2013/01/25