Re: [Qemu-devel] [PATCH 0/6] bdrv_open() error return fixes

[Anthony Liguori]

Hi,

Thank you for submitting your patch series.  checkpatch.pl has
detected that one or more of the patches in this series violate
the QEMU coding style.

If you believe this message was sent in error, please ignore it
or respond here with an explanation.

Otherwise, please correct the coding style issues and resubmit a
new version of the patch.

For more information about QEMU coding style, see:

http://git.qemu.org/?p=qemu.git;a=blob_plain;f=CODING_STYLE;hb=HEAD

Here is the output from checkpatch.pl:

Subject: parallels: Fix bdrv_open() error handling
Subject: dmg: Use g_free instead of free
Subject: dmg: Fix bdrv_open() error handling
ERROR: spaces required around that '=' (ctx:VxV)
#149: FILE: block/dmg.c:180:
+            for(i=s->n_chunks;i<s->n_chunks+chunk_count;i++) {
                  ^

ERROR: space required after that ';' (ctx:VxV)
#149: FILE: block/dmg.c:180:
+            for(i=s->n_chunks;i<s->n_chunks+chunk_count;i++) {
                              ^

ERROR: spaces required around that '<' (ctx:VxV)
#149: FILE: block/dmg.c:180:
+            for(i=s->n_chunks;i<s->n_chunks+chunk_count;i++) {
                                ^

ERROR: space required after that ';' (ctx:VxV)
#149: FILE: block/dmg.c:180:
+            for(i=s->n_chunks;i<s->n_chunks+chunk_count;i++) {
                                                        ^

ERROR: space required before the open parenthesis '('
#149: FILE: block/dmg.c:180:
+            for(i=s->n_chunks;i<s->n_chunks+chunk_count;i++) {

ERROR: space required before the open parenthesis '('
#206: FILE: block/dmg.c:236:
+    if(inflateInit(&s->zstream) != Z_OK) {

total: 6 errors, 0 warnings, 208 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Subject: vpc: Fix bdrv_open() error handling
ERROR: space prohibited before that close parenthesis ')'
#25: FILE: block/vpc.c:170:
+    if (ret < 0 ) {

total: 1 errors, 0 warnings, 84 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Subject: cloop: Fix bdrv_open() error handling
Subject: bochs: Fix bdrv_open() error handling


Regards,

Anthony Liguori