Re: [Qemu-devel] [PATCH V15 0/9] libqblock qemu block layer library

[Anthony Liguori]

Hi,

Thank you for submitting your patch series.  This patch breaks the build
by causing make to fail.  Here's the output:

  GEN   i386-softmmu/config-devices.mak
  GEN   x86_64-softmmu/config-devices.mak
  GEN   alpha-softmmu/config-devices.mak
  GEN   arm-softmmu/config-devices.mak
  GEN   cris-softmmu/config-devices.mak
  GEN   lm32-softmmu/config-devices.mak
  GEN   m68k-softmmu/config-devices.mak
  GEN   microblaze-softmmu/config-devices.mak
  GEN   microblazeel-softmmu/config-devices.mak
  GEN   mips-softmmu/config-devices.mak
  GEN   mipsel-softmmu/config-devices.mak
  GEN   mips64-softmmu/config-devices.mak
  GEN   ppc-softmmu/config-devices.mak
  GEN   ppcemb-softmmu/config-devices.mak
  GEN   mips64el-softmmu/config-devices.mak
  GEN   or32-softmmu/config-devices.mak
  GEN   ppc64-softmmu/config-devices.mak
  GEN   sh4-softmmu/config-devices.mak
  GEN   sh4eb-softmmu/config-devices.mak
  GEN   sparc64-softmmu/config-devices.mak
  GEN   sparc-softmmu/config-devices.mak
  GEN   s390x-softmmu/config-devices.mak
  GEN   xtensa-softmmu/config-devices.mak
  GEN   xtensaeb-softmmu/config-devices.mak
  GEN   unicore32-softmmu/config-devices.mak
  GEN   i386-linux-user/config-devices.mak
  GEN   x86_64-linux-user/config-devices.mak
  GEN   alpha-linux-user/config-devices.mak
  GEN   arm-linux-user/config-devices.mak
  GEN   cris-linux-user/config-devices.mak
  GEN   m68k-linux-user/config-devices.mak
  GEN   microblaze-linux-user/config-devices.mak
  GEN   microblazeel-linux-user/config-devices.mak
  GEN   armeb-linux-user/config-devices.mak
  GEN   mips-linux-user/config-devices.mak
  GEN   or32-linux-user/config-devices.mak
  GEN   mipsel-linux-user/config-devices.mak
  GEN   ppc-linux-user/config-devices.mak
  GEN   ppc64-linux-user/config-devices.mak
  GEN   ppc64abi32-linux-user/config-devices.mak
  GEN   sh4-linux-user/config-devices.mak
  GEN   sh4eb-linux-user/config-devices.mak
  GEN   sparc-linux-user/config-devices.mak
  GEN   sparc64-linux-user/config-devices.mak
  GEN   sparc32plus-linux-user/config-devices.mak
  GEN   unicore32-linux-user/config-devices.mak
  GEN   s390x-linux-user/config-devices.mak
  GEN   config-host.h
  GEN   qemu-options.def
  GEN   qmp-commands.h
  GEN   qapi-types.h
  GEN   qapi-visit.h
  GEN   trace/generated-tracers.h
  GEN   tests/test-qapi-types.h
  GEN   tests/test-qapi-visit.h
  GEN   tests/test-qmp-commands.h
  GEN   config-all-devices.mak
  lt CC libqblock/libqblock.lo
  lt CC stubs/arch-query-cpu-def.lo
  lt CC libqblock/libqblock-error.lo
  lt CC stubs/clock-warp.lo
  lt CC stubs/cpu-get-icount.lo
  lt CC stubs/cpu-get-clock.lo
  lt CC stubs/fdset-add-fd.lo
  lt CC stubs/fdset-find-fd.lo
  lt CC stubs/fdset-remove-fd.lo
  lt CC stubs/fdset-get-fd.lo
  lt CC stubs/get-fd.lo
  lt CC stubs/get-vm-name.lo
  lt CC stubs/migr-blocker.lo
  lt CC stubs/mon-is-qmp.lo
  lt CC stubs/iothread-lock.lo
  lt CC stubs/mon-printf.lo
  lt CC stubs/mon-print-filename.lo
  lt CC stubs/mon-protocol-event.lo
  lt CC stubs/mon-set-error.lo
  lt CC stubs/reset.lo
  lt CC stubs/slirp.lo
  lt CC stubs/sysbus.lo
  lt CC stubs/vm-stop.lo
  lt CC stubs/vmstate.lo
libqblock/libqblock.c: In function 'qb_create':
libqblock/libqblock.c:485:39: error: comparison between 
'QBlockFormatOptionsSDPreAlloc' and 'enum QBlockFormatOptionsVDIPreAlloc' 
[-Werror=enum-compare]
libqblock/libqblock.c:337:29: error: variable 'o_raw' set but not used 
[-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors
make: *** [libqblock/libqblock.lo] Error 1
make: *** Waiting for unfinished jobs....


Regards,

Anthony Liguori