Re: [Qemu-devel] [PATCH] vmware_vga: fix out of bounds and invalid rects updating

[Michael Tokarev]

25.01.2013 21:08, Anthony Liguori wrote:
> Michael Tokarev <address@hidden> writes:
> 
>> 25.01.2013 18:15, Anthony Liguori wrote:

>>> WARNING: __func__ should be used instead of gcc specific __FUNCTION__
>>> #73: FILE: hw/vmware_vga.c:300:
>>> +        fprintf(stderr, "%s: update x was < 0 (%d)\n", __FUNCTION__, x);

>>> Your patch has style problems, please review.  If any of these errors
>>> are false positives report them to the maintainer, see
>>> CHECKPATCH in MAINTAINERS.
>>
>> Okay.  I used the same style as were used in all the surrounding code.

> The patch is fine as-is.  Thanks for the explanation.

Actually it is not, and I'm wrong.  I used the wrong branch when cooked
my patch.  I'll resend.  All other places has already been converted
from __FUNCTION__ to __func__.

Sorry for the noize.

Thanks!

/mjt