[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control R
From: |
Laszlo Ersek |
Subject: |
Re: [Qemu-devel] [PATCH v3] PIIX3: reset the VM when the Reset Control Register's RCPU bit gets set |
Date: |
Fri, 25 Jan 2013 18:20:08 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108 Thunderbird/10.0.12 |
Hi,
On 01/25/13 15:18, Anthony Liguori wrote:
> If you believe this message was sent in error, please ignore it
> or respond here with an explanation.
>
> Otherwise, please correct the coding style issues and resubmit a
> new version of the patch.
>
> For more information about QEMU coding style, see:
>
> http://git.qemu.org/?p=qemu.git;a=blob_plain;f=CODING_STYLE;hb=HEAD
>
> Here is the output from checkpatch.pl:
>
> Subject: PIIX3: reset the VM when the Reset Control Register's RCPU bit gets
> set
> ERROR: space prohibited before open square bracket '['
> #164: FILE: hw/piix_pci.c:490:
> + .fields = (VMStateField []) {
>
> ERROR: space prohibited before open square bracket '['
> #178: FILE: hw/piix_pci.c:509:
> + .subsections = (VMStateSubsection []) {
>
> total: 2 errors, 0 warnings, 112 lines checked
>
> Your patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
The subscript operator [] is used here in the type name of a compound
literal which is probably not what the script intends to catch.
1945 # check for spacing round square brackets; allowed:
1946 # 1. with a type on the left -- int [] a;
The code in question was copied from "docs/migration.txt" and seems to
match existing practice:
git grep -E '(VMStateField|VMStateSubsection) \[]' \
| wc -l
139
Thanks
Laszlo