Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions

[Richard Henderson]

On 2013-01-25 06:18, Anthony Liguori wrote:
> Hi,
>
> Thank you for submitting your patch series.  checkpatch.pl has
> detected that one or more of the patches in this series violate
> the QEMU coding style.
>
> If you believe this message was sent in error, please ignore it
> or respond here with an explanation.
...
> Subject: target-i386: Implement ADX extension
> WARNING: braces {} are necessary for all arms of this statement
> #221: FILE: target-i386/translate.c:4247:
> +                    if (ot == OT_LONG) {
> [...]
> +                    } else
> [...]

Checkpatch doesn't work well with the pattern

#ifdef SOMETHING
    if (foo) {
        bar();
    } else
#endif
    {
        baz1();
        baz2();
    }

Which is exactly the case for all three errors reported in this series.
I know of no other good way to arrange this pattern.


r~