Re: [Qemu-devel] [PATCH 00/57] target-i386 eflags cleanup and bmi/adx extensions

[Richard Henderson]

On 2013-01-25 10:16, Eric Blake wrote:
> > >Which is exactly the case for all three errors reported in this series.
> > >I know of no other good way to arrange this pattern.
> #ifdef SOMETHING
> # define SOMETHING_WITNESS 1
> #else
> # define SOMETHING_WITNESS 0
> #endif
>
> if (foo && SOMETHING_WITNESS) {
>      bar();
> } else {
>      baz1();
>      baz2();
> }
>
> That is, hoist your #ifdeffery earlier into the file, and then you can
> avoid #ifdefs inside the function body, and thus avoid the checkpatch
> complaints; plus you get the benefit of testing that the code for
> SOMETHING compiles cleanly even when SOMETHING is not defined.

Well, in this case bar is not present when SOMETHING is undefined, which 
means that it definitely won't compile.

Fixing that is a significant amount of work inside tcg/tcg-op.h against 
which this patch series should not be held up against.


r~