Re: [Qemu-devel] [PATCH] PPC: Move ppc specific hw emulation to hw/ppc

[Alexander Graf]

On 25.01.2013, at 20:06, Blue Swirl wrote:

> On Fri, Jan 25, 2013 at 1:12 AM, Alexander Graf <address@hidden> wrote:
>> This patch moves all PowerPC specific hardware emulation except for
>> PREP to hw/ppc.
>> 
>> Signed-off-by: Alexander Graf <address@hidden>
>> ---
>> MAINTAINERS                  |   20 ++++++++++----------
>> hw/Makefile.objs             |   16 +---------------
>> hw/ppc/Makefile.objs         |   38 ++++++++++++++++++++++++++++++--------
>> hw/{ => ppc}/adb.c           |    2 +-
>> hw/{ => ppc}/adb.h           |    2 +-
>> hw/{ => ppc}/cuda.c          |    4 ++--
>> hw/{ => ppc}/dec_pci.c       |   10 +++++-----
>> hw/{ => ppc}/dec_pci.h       |    0
> 
> Please don't, Sparc64 should also use this device.

I think it makes sense to move it back as soon as sparc64 actually starts using 
it. Potentially you could use the e500 pci controller on a possible future ARM 
machine or some other frankenstein combination, but that's not what the current 
code reflects.

If you feel strongly about it, I can just not move the dec pci controller, but 
I really don't think it makes sense unless you have patches or plan to have 
patches very soon.


Alex