[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.4] configure: Keep -Werror enabled for Rel
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH for-1.4] configure: Keep -Werror enabled for Release Candidates |
Date: |
Sun, 27 Jan 2013 16:20:36 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 27.01.2013 16:16, schrieb Andreas Färber:
> The automatic drop of -Werror during the RC phases has in the past led
> to warnings creeping into submaintainer trees.
>
> Last QEMU Summit it was concluded that -Werror should stay on and
> enabled only as part of the release process.
be disabled, obviously :)
> To relieve our release manager, instead of always enabling -Werror or
> doing some number magic, let's enable it depending on whether a .git/
> directory exists in the source tree.
>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> configure | 2 +-
> 1 Datei geändert, 1 Zeile hinzugefügt(+), 1 Zeile entfernt(-)
>
> diff --git a/configure b/configure
> index b7635e4..0657b1a 100755
> --- a/configure
> +++ b/configure
> @@ -1180,7 +1180,7 @@ fi
> z_version=`cut -f3 -d. $source_path/VERSION`
>
> if test -z "$werror" ; then
> - if test "$z_version" = "50" -a \
> + if test -d "$source_path/.git" -a \
> "$linux" = "yes" ; then
> werror="yes"
> else
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg