Re: [Qemu-devel] [RFC 10/19] target-alpha: Refactor debug output macros

[Peter Maydell]

On 28 January 2013 18:22, Richard Henderson <address@hidden> wrote:
> On 01/27/2013 05:32 AM, Andreas Färber wrote:
>> +#define LOG_DISAS(...) G_STMT_START \
>> +    if (ALPHA_DEBUG_DISAS) { \
>> +        qemu_log_mask(CPU_LOG_TB_IN_ASM, ## __VA_ARGS__); \
>> +    } \
>> +    G_STMT_END
>
>
> I see zero advantage to using G_STMT_START/END over the
> shorter and significantly more obvious direct use of do/while.

Strong agreement -- G_STMT_START/END is just pointless
obfuscation without even the rationale of matching a
glib interface.

-- PMM