qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 0/2] Improve 128-bit multiply primitives


From: Andreas Färber
Subject: Re: [Qemu-devel] [PATCH 0/2] Improve 128-bit multiply primitives
Date: Mon, 28 Jan 2013 20:21:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2

Am 28.01.2013 19:52, schrieb Richard Henderson:
> Richard Henderson (2):
>   host-utils: Use __int128 for mul[us]64
>   host-utils: Improve mulu64 and muls64

Please fix Coding Style warnings in the latter (e.g., no space before
parenthesis, spacing aroung = ).

More importantly I wonder if we could get unit tests for such code being
refactored?

Andreas

>  configure                 |  20 +++++++++
>  include/qemu/host-utils.h |  17 ++++----
>  util/host-utils.c         | 102 
> ++++++++++++++++++----------------------------
>  3 files changed, 68 insertions(+), 71 deletions(-)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]