[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variab
|
From: |
Gerd Hoffmann |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] usb-ehci: replace PORTSC macros with variables |
|
Date: |
Tue, 29 Jan 2013 09:21:19 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108 Thunderbird/10.0.12 |
On 01/29/13 07:42, Kuo-Jung Su wrote:
> Hi Gerd:
>
> Thanks for reminding me of the usb_ehci_pci_initfn.
>
> But I have a stupid question.......
>
> Which one do the upcoming path v2 looks like ?
>
> 1. It contains only the diff to usb_ehci_pci_initfn, for example:
>
> [Qemu-devel][PATCH v2 0/1] usb-ehci: add Faraday FUSBH200 support
> [Qemu-devel][PATCH v2 1/1] usb-ehci: update usb_ehci_pci_initfn to use
> variable version of portsc
>
> 2. It contains the entired change logs, for example:
>
> [Qemu-devel][PATCH v2 0/3] usb-ehci: add Faraday FUSBH200 support
> [Qemu-devel][PATCH v2 1/3] usb-ehci: replace PORTSC macros with
> variables ..
> [Qemu-devel][PATCH v2 2/3] usb-ehci: add Faraday FUSBH200 support
> [Qemu-devel][PATCH v2 3/3] usb-ehci: update usb_ehci_pci_initfn ...
>
> I know this is stupid, but I really need the answer.
> Thanks you!
(3) - Update patch #1 to also change usb_ehci_pci_initfn. If you have
the usb_ehci_pci_initfn update as separate commit now you can use
'git rebase' to squash.
- Waiting a bit for more feedback (Andreas might want comment on
patch #2).
- Resend everything.
cheers,
Gerd