[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols. |
Date: |
Tue, 29 Jan 2013 14:25:42 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:13.0) Gecko/20120605 Thunderbird/13.0 |
Am 29.01.2013 14:07, schrieb Benoît Canet:
>> Wait, what's happening here? I don't understand this patch and how it's
>> related to snapshotting non-file protocols (if this is even what you
>> mean). What is your exact scenario, what does the existing code do in
>> it, and how does this change improve it? An empty commit message is
>> definitely not appropriate for such a change.
>>
>> In any case, using NULL as drv for bdrv_open() looks plain wrong.
>
> When passing drv bdrv_open tries to open the url as qcow2 or another plain
> file
> format and fail.
What exactly is a "plain file format" and what is the difference between
it and other file formats?
Anyway, this is not a problem description, let alone a description of
your exact scenario.
If qcow2 is specified as the format in the QMP command, why is it then
wrong to try and open the file as qcow2? Why does it fail? What is the
correct driver?
> bdrv_file_open is not a better option because it won't return a
> BlockDriverState
> constructed in the same way as the old one.
> (raw as bs and quorum as ->file)
>
> I agree that this patch is a hack and I am looking for a better way of doing
> it.
Let's talk about the problem first before discussing solutions.
Kevin
- [Qemu-devel] [PATCH V2 0/4] Pave the way for protocol snapshot creation, Benoît Canet, 2013/01/28
- [Qemu-devel] [PATCH V2 2/4] block: make path_hash_protocol public., Benoît Canet, 2013/01/28
- [Qemu-devel] [PATCH V2 1/4] block: Add option to do external snapshot image creation in the block drivers., Benoît Canet, 2013/01/28
- [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols., Benoît Canet, 2013/01/28
- Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols., Kevin Wolf, 2013/01/29
- Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols., Benoît Canet, 2013/01/29
- Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols.,
Kevin Wolf <=
- Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols., Benoît Canet, 2013/01/29
- Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols., Kevin Wolf, 2013/01/29
- Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols., Benoît Canet, 2013/01/29
- Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols., Eric Blake, 2013/01/29
- Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols., Benoît Canet, 2013/01/29
- Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols., Kevin Wolf, 2013/01/29
- Re: [Qemu-devel] [PATCH V2 3/4] blockdev: Allow snapshoting of protocols., Benoît Canet, 2013/01/29
[Qemu-devel] [PATCH V2 4/4] block: Optionally block drivers to optionally reopen images after snapshot creation., Benoît Canet, 2013/01/28