[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions.
From: |
Alexander Graf |
Subject: |
Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions. |
Date: |
Tue, 29 Jan 2013 16:09:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.3) Gecko/20120306 Thunderbird/10.0.3 |
On 01/28/2013 10:59 AM, Cornelia Huck wrote:
On Fri, 25 Jan 2013 20:28:31 +0100
Alexander Graf<address@hidden> wrote:
However, I do agree that this duplicates logic. Cornelia, mind to instead call
our map helper in css_do_tpi?
Well, ioinst_handle_tpi() looks like the better place to do this.
Can you put this into the series, or should I re-send?
It still breaks for 32-bit targets. Could you please replace the set_bit
call by normal bit shift operations?
Alex
<afaerber_> CC s390x-softmmu/hw/s390x/virtio-ccw.o
<afaerber_> CC s390x-softmmu/target-s390x/translate.o
<afaerber_> CC s390x-softmmu/target-s390x/helper.o
<afaerber_> /home/andreas/QEMU/qemu-s390/hw/s390x/virtio-ccw.c: In
function 'virtio_ccw_notify':
<afaerber_> /home/andreas/QEMU/qemu-s390/hw/s390x/virtio-ccw.c:665:9:
warning: passing argument 2 of 'set_bit' from incompatible pointer type
[enabled by default]
<afaerber_> In file included from
/home/andreas/QEMU/qemu-s390/hw/s390x/virtio-ccw.c:22:0:
<afaerber_> /home/andreas/QEMU/qemu-s390/include/qemu/bitops.h:117:20:
note: expected 'long unsigned int *' but argument is of type 'uint64_t *'
* rastal (address@hidden) has joined #qemu
<afaerber_> /home/andreas/QEMU/qemu-s390/hw/s390x/virtio-ccw.c:670:9:
warning: passing argument 2 of 'set_bit' from incompatible pointer type
[enabled by default]
<afaerber_> In file included from
/home/andreas/QEMU/qemu-s390/hw/s390x/virtio-ccw.c:22:0:
<mjt> whee
<afaerber_> /home/andreas/QEMU/qemu-s390/include/qemu/bitops.h:117:20:
note: expected 'long unsigned int *' but argument is of type 'uint64_t *'
<afaerber_> agraf: ^
if (vector < VIRTIO_PCI_QUEUE_MAX) {
indicators = ldq_phys(dev->indicators);
set_bit(vector, &indicators);
^^
stq_phys(dev->indicators, indicators);
} else {
vector = 0;
indicators = ldq_phys(dev->indicators2);
set_bit(vector, &indicators);
stq_phys(dev->indicators2, indicators);
}
- [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions., (continued)
- Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions., Cornelia Huck, 2013/01/28
- Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions., Alexander Graf, 2013/01/28
- Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions.,
Alexander Graf <=
- Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions., Cornelia Huck, 2013/01/29
- Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions., Blue Swirl, 2013/01/29
- Re: [Qemu-devel] [PATCH 06/15] s390: Add channel I/O instructions., Alexander Graf, 2013/01/29
[Qemu-devel] [PATCH 10/15] s390: Add new channel I/O based virtio transport., Alexander Graf, 2013/01/25
[Qemu-devel] [PATCH 14/15] s390-virtio: Check for NULL device in reset hypercall, Alexander Graf, 2013/01/25
[Qemu-devel] [PATCH 11/15] s390: Make typeinfo const, Alexander Graf, 2013/01/25
[Qemu-devel] [PATCH 08/15] s390: Wire up channel I/O in kvm., Alexander Graf, 2013/01/25
[Qemu-devel] [PATCH 12/15] virtio-s390: add a reset function to virtio-s390 devices, Alexander Graf, 2013/01/25
[Qemu-devel] [PATCH 07/15] s390: Virtual channel subsystem support., Alexander Graf, 2013/01/25
[Qemu-devel] [PATCH 09/15] s390-virtio: Factor out some initialization code., Alexander Graf, 2013/01/25