[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 19/19] s390: Drop set_bit usage in virtio_ccw.
From: |
Alexander Graf |
Subject: |
[Qemu-devel] [PATCH 19/19] s390: Drop set_bit usage in virtio_ccw. |
Date: |
Tue, 29 Jan 2013 21:50:59 +0100 |
From: Cornelia Huck <address@hidden>
set_bit on indicators doesn't go well on 32 bit targets:
note: expected 'long unsigned int *' but argument is of type 'uint64_t *'
Switch to bit shifts instead.
Signed-off-by: Cornelia Huck <address@hidden>
[agraf: use 1ULL instead]
Signed-off-by: Alexander Graf <address@hidden>
---
hw/s390x/virtio-ccw.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index 7d7f336..231f81e 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -662,12 +662,12 @@ static void virtio_ccw_notify(DeviceState *d, uint16_t
vector)
if (vector < VIRTIO_PCI_QUEUE_MAX) {
indicators = ldq_phys(dev->indicators);
- set_bit(vector, &indicators);
+ indicators |= 1ULL << vector;
stq_phys(dev->indicators, indicators);
} else {
vector = 0;
indicators = ldq_phys(dev->indicators2);
- set_bit(vector, &indicators);
+ indicators |= 1ULL << vector;
stq_phys(dev->indicators2, indicators);
}
--
1.6.0.2
- [Qemu-devel] [PATCH 04/19] s390: Channel I/O basic definitions., (continued)
- [Qemu-devel] [PATCH 04/19] s390: Channel I/O basic definitions., Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 03/19] s390: Add mapping helper functions., Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 05/19] s390: I/O interrupt and machine check injection., Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 11/19] s390: Make typeinfo const, Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 12/19] virtio-s390: add a reset function to virtio-s390 devices, Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 01/19] s390: Add default support for SCLP console, Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 15/19] s390: Add s390-ccw-virtio machine., Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 09/19] s390-virtio: Factor out some initialization code., Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 08/19] s390: Wire up channel I/O in kvm., Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 13/19] s390: Move hw files to hw/s390x, Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 19/19] s390: Drop set_bit usage in virtio_ccw.,
Alexander Graf <=
- [Qemu-devel] [PATCH 14/19] s390-virtio: Check for NULL device in reset hypercall, Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 16/19] sclpconsole: Don't instantiate sclpconsole with -nodefaults, Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 06/19] s390: Add channel I/O instructions., Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 18/19] s390: css error codes., Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 17/19] s390: Use s390_cpu_physical_memory_map for tpi., Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 10/19] s390: Add new channel I/O based virtio transport., Alexander Graf, 2013/01/29
- [Qemu-devel] [PATCH 07/19] s390: Virtual channel subsystem support., Alexander Graf, 2013/01/29