Re: [Qemu-devel] What to do about non-qdevified devices?

[Andreas Färber]

Am 30.01.2013 08:02, schrieb Markus Armbruster:
> Anthony Liguori <address@hidden> writes:
> 
> [...]
>> The problems I ran into were (1) this is a lot of work (2) it basically
>> requires that all bus children have been qdev/QOM-ified.  Even with
>> something like the ISA bus which is where I started, quite a few devices
>> were not qdevified still.
> 
> So what's the plan to complete the qdevification job?  Lay really low
> and quietly hope the problem goes away?  We've tried that for about
> three years, doesn't seem to work.

Stating (file) names would make that discussion much easier... ;)

I'd expect non-qdev'ified devices to rather be SysBusDevices (e.g.,
m68k, sh4, ppc). PReP's pc87312 qdev'ification was forgotten for 1.2 and
recently merged.
Would dma.c be a candidate for ISADevice? It uses isa_* API. (The stubs
in sun4m.c/sun4u.c due to use in fdc.c might be a candidate for stubs/
at least, short of an fdc.c rewrite.)

I recently went through all ISADevices and QOM'ified them:
https://lists.gnu.org/archive/html/qemu-devel/2012-11/msg02746.html

It became too late for 1.4 and I'm not quite sure where Anthony wanted
to draw the line between his 1) and 2):
https://lists.gnu.org/archive/html/qemu-devel/2013-01/msg00071.html
Thus I've only been rebasing my queue [1] without sending a v2 so far.

Lack of an official ISA maintainer for reviewing is another issue, any
volunteers? :)

Cheers,
Andreas

[1] https://github.com/afaerber/qemu-cpu/commits/realize-isa

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg