Re: [Qemu-devel] [RFC PATCH RDMA support v1: 1/5] add openfabrics RDMA libraries and base RDMA code to build

[Stefan Hajnoczi]

On Mon, Jan 28, 2013 at 05:01:41PM -0500, address@hidden wrote:
> From: "Michael R. Hines" <address@hidden>
> 
> 
> Signed-off-by: Michael R. Hines <address@hidden>
> ---
>  Makefile.target     |    5 +-
>  include/qemu/rdma.h |  249 ++++++++++
>  qemu-rdma.c         | 1357 
> +++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 1609 insertions(+), 2 deletions(-)
>  create mode 100644 include/qemu/rdma.h
>  create mode 100644 qemu-rdma.c
> 
> diff --git a/Makefile.target b/Makefile.target
> index 760da1e..d1d6b8c 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -112,12 +112,13 @@ obj-y += arch_init.o cpus.o monitor.o gdbstub.o 
> balloon.o ioport.o
>  obj-y += hw/
>  obj-$(CONFIG_KVM) += kvm-all.o
>  obj-$(CONFIG_NO_KVM) += kvm-stub.o
> -obj-y += memory.o savevm.o cputlb.o
> +# "tracefunc.o" will go away - I use GCC's -finstrument-functions support 
> inside tracefunc.o
> +obj-y += memory.o savevm.o cputlb.o qemu-rdma.o #tracefunc.o

Please drop tracefunc.o.

>  obj-$(CONFIG_HAVE_GET_MEMORY_MAPPING) += memory_mapping.o
>  obj-$(CONFIG_HAVE_CORE_DUMP) += dump.o
>  obj-$(CONFIG_NO_GET_MEMORY_MAPPING) += memory_mapping-stub.o
>  obj-$(CONFIG_NO_CORE_DUMP) += dump-stub.o
> -LIBS+=-lz
> +LIBS+=-lz -lrdmacm

This needs to be a ./configure option.  Not all users will choose to
build with RDMA support and rdmacm may not be available on all host
platforms.

Stefan