qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 2/4] trace: Direct access of atomics is verboten


From: Laszlo Ersek
Subject: Re: [Qemu-devel] [PATCH 2/4] trace: Direct access of atomics is verboten, use the API
Date: Thu, 31 Jan 2013 12:25:30 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130108 Thunderbird/10.0.12

On 01/25/13 16:43, Markus Armbruster wrote:
> The GLib Reference Manual says:
> 
>     It is very important that all accesses to a particular integer or
>     pointer be performed using only this API and that different sizes
>     of operation are not mixed or used on overlapping memory
>     regions. Never read or assign directly from or to a value --
>     always use this API.
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  trace/simple.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)

Nothing beats a patch summary with a word that English loans from the
submitter's mother tongue! :) Extra points for the Vau.

Reviewed-by: Laszlo Ersek <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]