[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 01/12] host-utils: add ffsl
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH v2 01/12] host-utils: add ffsl |
Date: |
Thu, 31 Jan 2013 13:27:44 +0100 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Jan 16, 2013 at 06:31:08PM +0100, Paolo Bonzini wrote:
> We can provide fast versions based on the other functions defined
> by host-utils.h. Some care is required on glibc, which provides
> ffsl already.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
> include/qemu/host-utils.h | 26 ++++++++++++++++++++++++++
> 1 files changed, 26 insertions(+), 0 deletions(-)
Speaking of ffsl() issues, mingw32 now complains about ffsl() being
undefined in hbitmap:
In file included from /home/stefanha/qemu/include/block/block_int.h:35:0,
from qemu-img.c:32:
/home/stefanha/qemu/include/qemu/hbitmap.h: In function 'hbitmap_iter_next':
/home/stefanha/qemu/include/qemu/hbitmap.h:173:5: warning: implicit declaration
of function 'ffsl' [-Wimplicit-function-declaration]
Using mingw32-gcc-4.7.2-7.fc18. I haven't looked into this but I
thought ffsl() was a gcc built-in and it wouldn't require any headers.
Stefan
- [Qemu-devel] [PATCH v2 00/12] Drive mirroring performance improvements, Paolo Bonzini, 2013/01/16
- [Qemu-devel] [PATCH v2 01/12] host-utils: add ffsl, Paolo Bonzini, 2013/01/16
- [Qemu-devel] [PATCH v2 03/12] block: implement dirty bitmap using HBitmap, Paolo Bonzini, 2013/01/16
- [Qemu-devel] [PATCH v2 02/12] add hierarchical bitmap data type and test cases, Paolo Bonzini, 2013/01/16
- [Qemu-devel] [PATCH v2 04/12] block: make round_to_clusters public, Paolo Bonzini, 2013/01/16
- [Qemu-devel] [PATCH v2 05/12] mirror: perform COW if the cluster size is bigger than the granularity, Paolo Bonzini, 2013/01/16