[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-1.4 v3] linux-user: bsd-user: Don't reset X8
|
From: |
Andreas Färber |
|
Subject: |
Re: [Qemu-devel] [PATCH for-1.4 v3] linux-user: bsd-user: Don't reset X86CPU twice |
|
Date: |
Fri, 01 Feb 2013 01:06:17 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130105 Thunderbird/17.0.2 |
Am 31.01.2013 21:40, schrieb Andreas Färber:
> Since commit 65dee38052597b6285eb208125369f01b29ba6c1 (target-i386:
> move cpu_reset and reset callback to cpu.c) the x86 CPU is reset through
> cpu_init() but was still reset immediately after in linux-user and
> bsd-user. Clean this up.
>
> Similarly it is also reset after cpu_copy(), but that's a bug of its own.
>
> Reviewed-by: Igor Mammedov <address@hidden>
> Signed-off-by: Andreas Färber <address@hidden>
> ---
> v2 -> v3:
> * Don't touch cpu_copy() at all, only fixing the double reset
> and not changing cpu_copy() behavior.
Applied this stripped-down version to qom-cpu:
https://github.com/afaerber/qemu-cpu/commits/qom-cpu
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg