[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 03/12] target-xtensa: Mark as unmigratable
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PATCH 03/12] target-xtensa: Mark as unmigratable |
Date: |
Fri, 1 Feb 2013 01:44:31 +0100 |
There was no CPU_SAVE_VERSION defined, so neither "cpu_common" VMState
nor cpu_{save,load}() were registered. Their implementation was no-op.
Therefore there is no backwards compatibility to keep, so mark XtensaCPU
as unmigratable at device level.
Signed-off-by: Andreas Färber <address@hidden>
Reviewed-by: Juan Quintela <address@hidden>
---
target-xtensa/Makefile.objs | 1 -
target-xtensa/cpu.c | 9 +++++++++
target-xtensa/machine.c | 38 --------------------------------------
3 Dateien geändert, 9 Zeilen hinzugefügt(+), 39 Zeilen entfernt(-)
delete mode 100644 target-xtensa/machine.c
diff --git a/target-xtensa/Makefile.objs b/target-xtensa/Makefile.objs
index b30e5a8..644b7f9 100644
--- a/target-xtensa/Makefile.objs
+++ b/target-xtensa/Makefile.objs
@@ -3,4 +3,3 @@ obj-y += core-dc232b.o
obj-y += core-dc233c.o
obj-y += core-fsf.o
obj-y += translate.o op_helper.o helper.o cpu.o
-obj-$(CONFIG_SOFTMMU) += machine.o
diff --git a/target-xtensa/cpu.c b/target-xtensa/cpu.c
index 035b07c..ebc7e99 100644
--- a/target-xtensa/cpu.c
+++ b/target-xtensa/cpu.c
@@ -30,6 +30,7 @@
#include "cpu.h"
#include "qemu-common.h"
+#include "migration/vmstate.h"
/* CPUClass::reset() */
@@ -64,13 +65,21 @@ static void xtensa_cpu_initfn(Object *obj)
cpu_exec_init(env);
}
+static const VMStateDescription vmstate_xtensa_cpu = {
+ .name = "cpu",
+ .unmigratable = 1,
+};
+
static void xtensa_cpu_class_init(ObjectClass *oc, void *data)
{
+ DeviceClass *dc = DEVICE_CLASS(oc);
CPUClass *cc = CPU_CLASS(oc);
XtensaCPUClass *xcc = XTENSA_CPU_CLASS(cc);
xcc->parent_reset = cc->reset;
cc->reset = xtensa_cpu_reset;
+
+ dc->vmsd = &vmstate_xtensa_cpu;
}
static const TypeInfo xtensa_cpu_type_info = {
diff --git a/target-xtensa/machine.c b/target-xtensa/machine.c
deleted file mode 100644
index ddeffb2..0000000
--- a/target-xtensa/machine.c
+++ /dev/null
@@ -1,38 +0,0 @@
-/*
- * Copyright (c) 2011, Max Filippov, Open Source and Linux Lab.
- * All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions are met:
- * * Redistributions of source code must retain the above copyright
- * notice, this list of conditions and the following disclaimer.
- * * Redistributions in binary form must reproduce the above copyright
- * notice, this list of conditions and the following disclaimer in the
- * documentation and/or other materials provided with the distribution.
- * * Neither the name of the Open Source and Linux Lab nor the
- * names of its contributors may be used to endorse or promote products
- * derived from this software without specific prior written permission.
- *
- * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
- * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
- * ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY
- * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES
- * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
- * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND
- * ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
- * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
THIS
- * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-#include "hw/hw.h"
-#include "hw/boards.h"
-
-void cpu_save(QEMUFile *f, void *opaque)
-{
-}
-
-int cpu_load(QEMUFile *f, void *opaque, int version_id)
-{
- return 0;
-}
--
1.7.10.4
- [Qemu-devel] [PULL 00/12] QOM CPUState patch queue 2013-02-01, Andreas Färber, 2013/01/31
- [Qemu-devel] [PATCH 02/12] target-microblaze: Mark as unmigratable, Andreas Färber, 2013/01/31
- [Qemu-devel] [PATCH 04/12] target-sh4: Mark as unmigratable, Andreas Färber, 2013/01/31
- [Qemu-devel] [PATCH 01/12] target-unicore32: Mark as unmigratable, Andreas Färber, 2013/01/31
- [Qemu-devel] [PATCH 07/12] target-m68k: Rename CPU subtypes, Andreas Färber, 2013/01/31
- [Qemu-devel] [PATCH 06/12] target-m68k: Mark as unmigratable, Andreas Färber, 2013/01/31
- [Qemu-devel] [PATCH 05/12] target-s390x: Mark as unmigratable, Andreas Färber, 2013/01/31
- [Qemu-devel] [PATCH 11/12] target-i386: Pass X86CPU to cpu_x86_set_a20(), Andreas Färber, 2013/01/31
- [Qemu-devel] [PATCH 08/12] target-openrisc: TYPE_OPENRISC_CPU should be abstract, Andreas Färber, 2013/01/31
- [Qemu-devel] [PATCH 10/12] target-unicore32: Rename CPU subtypes, Andreas Färber, 2013/01/31
- [Qemu-devel] [PATCH 03/12] target-xtensa: Mark as unmigratable,
Andreas Färber <=
- [Qemu-devel] [PATCH 09/12] target-openrisc: Rename CPU subtypes, Andreas Färber, 2013/01/31
- [Qemu-devel] [PATCH 12/12] linux-user: bsd-user: Don't reset X86CPU twice, Andreas Färber, 2013/01/31